projjal commented on a change in pull request #10068:
URL: https://github.com/apache/arrow/pull/10068#discussion_r622747180
##########
File path: cpp/src/gandiva/gdv_function_stubs_test.cc
##########
@@ -220,6 +220,32 @@ TEST(TestGdvFnStubs, TestCastVARCHARFromInt64) {
EXPECT_FALSE(ctx.has_error());
}
+TEST(TestGdvFnStubs, TestCastVARCHARFromMilliseconds) {
+ gandiva::ExecutionContext ctx;
+ uint64_t ctx_ptr = reinterpret_cast<int64_t>(&ctx);
+ int32_t out_len = 0;
+
+ const char* out_str = gdv_fn_castVARCHAR_date64_int64(ctx_ptr,
1619218598237, 100, &out_len);
Review comment:
This numbers are not helpful for understanding. can you add helper
function to convert then to long. Look at StringToTimestamp in
precompiled/time_test.cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
