pitrou commented on code in PR #48943:
URL: https://github.com/apache/arrow/pull/48943#discussion_r2735556631
##########
cpp/src/arrow/testing/random.cc:
##########
@@ -1475,4 +1475,75 @@ void rand_month_day_nanos(int64_t N,
});
}
+std::string RandomUtf8String(int num_chars) {
+ std::random_device rd;
+ std::default_random_engine gen(rd());
Review Comment:
Can we make the seeding deterministic? Perhaps pass an explicit seed to this
function. We want tests to be reproducible reliably.
(also, we're using `pcg32` in other random generation functions, perhaps use
it here too?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
