daniel-adam-tfs commented on code in PR #547:
URL: https://github.com/apache/arrow-go/pull/547#discussion_r2737567408
##########
parquet/file/page_reader.go:
##########
@@ -451,12 +477,17 @@ func NewPageReader(r parquet.BufferedReader, nrows int64,
compressType compress.
func (p *serializedPageReader) Reset(r parquet.BufferedReader, nrows int64,
compressType compress.Compression, ctx *CryptoContext) {
Review Comment:
If I could change the signature of Reset of the `PageReader` interface to
use `parquet.BufferedReaderV2` I could skip the whole `bufferedReaderV2Adapter`
shenanigans, but `NewPageReader` and `RecordReader.SetPageReader` are public
API. But if they get ever removed from public API then we can get rid of
`bufferedReaderV2Adapter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
