rok commented on code in PR #48601:
URL: https://github.com/apache/arrow/pull/48601#discussion_r2738473423
##########
docs/source/python/install.rst:
##########
@@ -83,35 +83,36 @@ and **pytz**, **dateutil** or **tzdata** package for
timezones.
tzdata on Windows
^^^^^^^^^^^^^^^^^
-While Arrow uses the OS-provided timezone database on Linux and macOS, it
requires a
-user-provided database on Windows. To download and extract the text version of
+On Linux and macOS, Arrow uses the OS-provided timezone database. On Windows,
+Arrow uses the Windows timezone database when built with MSVC or recent MinGW
GCC
+(version 13+), which covers most pre-built packages. No additional setup is
needed
+for these builds.
+
+However, when PyArrow is built with Clang/libc++ on Windows, a user-provided
+IANA timezone database is required. To download and extract the text version of
the IANA timezone database follow the instructions in the C++
-:ref:`download-timezone-database` or use pyarrow utility function
-``pyarrow.util.download_tzdata_on_windows()`` that does the same.
+:ref:`download-timezone-database` or use the (deprecated) pyarrow utility
function
+``pyarrow.util.download_tzdata_on_windows()``.
By default, the timezone database will be detected at
``%USERPROFILE%\Downloads\tzdata``.
If the database has been downloaded in a different location, you will need to
set
-a custom path to the database from Python:
-
-.. code-block:: python
+a custom path to the database from Python using the (deprecated)
+``pa.set_timezone_db_path("custom_path")`` function.
- >>> import pyarrow as pa
- >>> pa.set_timezone_db_path("custom_path")
-
-You may encounter problems writing datetime data to an ORC file if you install
-pyarrow with pip. One possible solution to fix this problem:
+.. note::
+ You may encounter problems writing datetime data to an ORC file if you
install
+ pyarrow with pip. One possible solution to fix this problem:
Review Comment:
I didn't find any indications they did,
[their](https://github.com/apache/orc/issues/1577) and
[our](https://github.com/apache/arrow/issues/46080) issues. They also appear to
[be on
C++17](https://github.com/apache/orc/blob/2e585079ad6f8e4e9701cdaf7c5814d13f31bdf4/CMakeLists.txt#L107).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
