alamb commented on code in PR #9278:
URL: https://github.com/apache/arrow-rs/pull/9278#discussion_r2738914109


##########
arrow-select/src/take.rs:
##########
@@ -63,7 +63,7 @@ use num_traits::{One, Zero};
 ///
 /// # Safety
 ///
-/// When `options` is not set to check bounds, taking indexes after `len` will 
panic.
+/// When `options` is not set to check bounds, taking indexes after `len` is 
*undefined behavior*.

Review Comment:
   Maybe we need to add a `fn unsafe take_unchecked` 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to