raulcd commented on PR #49047: URL: https://github.com/apache/arrow/pull/49047#issuecomment-3818802601
To be honest I've never used the benchmark.h/.cc but it is being built as part of pyarrow: https://github.com/apache/arrow/blob/9b0885ade1c8bbefa173e79391c2f1a61b93456d/python/CMakeLists.txt#L353-L355 And used (libarrow_python/benchmar.pxi/benchmark.py): https://github.com/apache/arrow/blob/222fac73a0425e6c273ba8e0b5a427091ee56245/python/pyarrow/includes/libarrow_python.pxd#L282-L283 https://github.com/apache/arrow/blob/222fac73a0425e6c273ba8e0b5a427091ee56245/python/pyarrow/benchmark.pxi#L19-L20 https://github.com/apache/arrow/blob/222fac73a0425e6c273ba8e0b5a427091ee56245/python/pyarrow/benchmark.py#L21 and finally used on the microbenchmarks: https://github.com/apache/arrow/blob/222fac73a0425e6c273ba8e0b5a427091ee56245/python/benchmarks/microbenchmarks.py#L44-L45 I think this could potentially still be used no matter whether we remove the asv files or not but happy to discuss whether we should remove all this infrastructure as I am unsure is being used/tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
