tustvold commented on code in PR #9272:
URL: https://github.com/apache/arrow-rs/pull/9272#discussion_r2742894183
##########
arrow-json/src/lib.rs:
##########
@@ -86,7 +86,7 @@
pub mod reader;
pub mod writer;
-pub use self::reader::{Reader, ReaderBuilder};
+pub use self::reader::{ArrayDecoder, DecoderFactory, Reader, ReaderBuilder,
Tape, TapeElement};
Review Comment:
There were some discussions a while back about the way that it copies all
strings from the source data being unfortunate. I'm not sure how this is
avoidable with the push-based decoder interface, but it has been discussed.
TBC I am not against making Tape public, but it likely needs some TLC prior
to that to ensure it is usable and vaguely future-proof. Even basic things like
adding non_exhaustive, hiding methods like
[this](https://github.com/apache/arrow-rs/blob/7e5076f1f775a6fd08a4d63389e26e2920fe3f6a/arrow-json/src/reader/tape.rs#L209)
that are a bit odd to expose, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
