felipecrv commented on PR #3930: URL: https://github.com/apache/arrow-adbc/pull/3930#issuecomment-3820917904
@zeroshade I have more to do here, but any early feedback on the approach is appreciated. If the overall diff ends up confusing, you can see it commit by commit. This refactoring allowed me to find an UX issue: if we fail to parse a manifest, we might swallow the error and succeed because we later find a library somewhere instead of stopping early and rendering the error message about the manifest parsing. I will fix it in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
