HyukjinKwon opened a new pull request, #49077:
URL: https://github.com/apache/arrow/pull/49077

   ### Rationale for this change
   
   The `TypeEquals()` function has a fallback path for types without 
fingerprints, but it was not passing through the `check_metadata` parameter to 
`TypeEqualsVisitor`. While this is an really rare corner case, the check should 
still be there to prevent potential mistakes when, e.g., adding new types in 
the future.
   
   ### What changes are included in this PR?
   
   - Added test case 
`TestNestedType.FieldMetadataComparisonWithEmptyFingerprints` to verify the fix
   - Updated the TODO comment to clarify why the parameter must be passed 
through.
   
   ### Are these changes tested?
   
   Yes, unittest was added.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to