kou commented on code in PR #49062:
URL: https://github.com/apache/arrow/pull/49062#discussion_r2745856228
##########
cpp/cmake_modules/Findutf8proc.cmake:
##########
@@ -32,7 +32,9 @@ if(ARROW_VCPKG)
endif()
find_package(utf8proc NAMES unofficial-utf8proc ${find_package_args})
if(utf8proc_FOUND)
- add_library(utf8proc::utf8proc ALIAS utf8proc)
+ if(NOT TARGET utf8proc::utf8proc)
+ add_library(utf8proc::utf8proc ALIAS utf8proc)
+ endif()
return()
endif()
Review Comment:
Recent vcpkg's utf8proc CMake package provides `utf8proc::utf8proc` CMake
target, right?
If so, we can remove this `if` block entirely. We don't need to support old
vcpkg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
