Dandandan commented on issue #9296: URL: https://github.com/apache/arrow-rs/issues/9296#issuecomment-3823647915
Yeah sure - I do understand the needs a bit better after looking at https://github.com/apache/arrow-rs/pull/9303 Looking at `ColumnIndex`: ``` pub struct ColumnIndex { pub(crate) null_pages: Vec<bool>, pub(crate) boundary_order: BoundaryOrder, pub(crate) null_counts: Option<Vec<i64>>, pub(crate) repetition_level_histograms: Option<Vec<i64>>, pub(crate) definition_level_histograms: Option<Vec<i64>>, } ``` * `null_pages`: this currently is a `Vec<bool>` (true is null, false is non-null), it would be better to save this as a `NullBuffer` or similar, where `true` means valid and `false` means invalid * `null_counts`: Option<Vec<i64>>: it would be better to have this as a `Int64Array` or similar (Or preferably even `Uint64Array` if we can do the conversion earlier) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
