jorisvandenbossche commented on code in PR #49088:
URL: https://github.com/apache/arrow/pull/49088#discussion_r2747150383
##########
docs/source/python/data.rst:
##########
@@ -684,7 +684,7 @@ When using :class:`~.DictionaryArray` with pandas, the
analogue is
6 NaN
7 baz
dtype: category
- Categories (3, object): ['foo', 'bar', 'baz']
+ Categories (3, ...): ['foo', 'bar', 'baz']
Review Comment:
FWIW, I think if we know the doctests will run on an instance with
pandas>=3, I would just update those to use pandas 3 output, because that will
be less confusing for people reading the docs.
```suggestion
Categories (3, str): ['foo', 'bar', 'baz']
```
##########
docs/source/python/data.rst:
##########
@@ -648,7 +648,7 @@ Here we have:
.. code-block:: python
>>> print(dict_array.type)
- dictionary<values=string, indices=int64, ordered=0>
+ dictionary<values=...string, indices=int64, ordered=0>
Review Comment:
This one should not be needed? (the dictionary here is created just through
pyarrow, no pandas involved?)
##########
docs/source/python/ipc.rst:
##########
@@ -94,7 +94,7 @@ convenience function ``pyarrow.ipc.open_stream``:
... batches = [b for b in reader]
>>> schema
f0: int64
- f1: string
+ f1: ...string
Review Comment:
Also here, is this actually needed? The example here is pure pyarrow, and
that should always be using pyarrow's default of "string" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
