emkornfield commented on code in PR #48635: URL: https://github.com/apache/arrow/pull/48635#discussion_r2751997485
########## cpp/src/parquet/row_selection.h: ########## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstdint> +#include <vector> + +#include "arrow/util/span.h" +#include "parquet/platform.h" + +namespace parquet { + +/// RowSelection is a collection of non-overlapping and ascendingly ordered row ranges. +class PARQUET_EXPORT RowSelection { + public: + /// \brief EXPERIMENTAL: A range of contiguous rows represented by an interval. + struct IntervalRange { + /// Start row of the range (inclusive). + int64_t start; + /// Number of rows in the range. + int64_t length; + }; + + /// \brief EXPERIMENTAL: An iterator for accessing row ranges in batches. + class Iterator { + public: + virtual ~Iterator() = default; + /// \brief Get the next batch of ranges. + /// Returns an empty span when exhausted. + virtual ::arrow::util::span<const IntervalRange> NextRanges() = 0; + }; + + /// \brief EXPERIMENTAL: Create a new iterator for accessing row ranges in order. + std::unique_ptr<Iterator> NewIterator() const; + + /// \brief EXPERIMENTAL: Validate the row ranges. + /// \throws ParquetException if the row ranges are not in ascending order or + /// overlapped. + void Validate() const; Review Comment: It seems like validation should happen on construction? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
