alamb commented on code in PR #9327:
URL: https://github.com/apache/arrow-rs/pull/9327#discussion_r2755206919
##########
arrow-schema/src/datatype.rs:
##########
@@ -648,6 +648,23 @@ impl DataType {
matches!(self, Utf8 | LargeUtf8 | Utf8View)
}
+ /// Returns true if this type is a List type
Review Comment:
I recommend we explciitly document here what "List" means so people don't
have to look at the code to find out if it is just `List` or also includes
`ListView` and `FixedSizeList`
for example
```rust
/// Returns true if this type is a List type
///
/// List types include List, LargeList, FixedSizeList, ListView, and
LargeListView
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
