alamb commented on code in PR #9316:
URL: https://github.com/apache/arrow-rs/pull/9316#discussion_r2755217358
##########
arrow-arith/src/temporal.rs:
##########
@@ -189,7 +189,6 @@ pub fn date_part(array: &dyn Array, part: DatePart) ->
Result<ArrayRef, ArrowErr
DataType::Dictionary(_, _) => {
let array = array.as_any_dictionary();
let values = date_part(array.values(), part)?;
- let values = Arc::new(values) as ArrayRef;
Review Comment:
🤦
##########
arrow-ipc/src/reader.rs:
##########
@@ -1982,7 +1982,7 @@ mod tests {
Arc::new(array6),
Arc::new(array7),
Arc::new(array8),
- Arc::new(array9),
+ array9,
Review Comment:
nit this could leave this as an Arc for consistency and remove the arc from
above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
