Jefffrey opened a new issue, #9339:
URL: https://github.com/apache/arrow-rs/issues/9339

   **Is your feature request related to a problem or challenge? Please describe 
what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always 
frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for 
this feature, in addition to  the *what*)
   -->
   
   I've seen some PRs where replacing usage of `MutableArrayData` with the 
`take` kernel can significantly improve performance
   
   - Example from DataFusion: https://github.com/apache/datafusion/pull/20049
   
   Consider following this approach for the code that casts list/listviews to 
fixedsizelists:
   
   
https://github.com/apache/arrow-rs/blob/dc99a52498ec25dae1fdc12618e992764486b88c/arrow-cast/src/cast/list.rs#L143-L154
   
   
https://github.com/apache/arrow-rs/blob/dc99a52498ec25dae1fdc12618e992764486b88c/arrow-cast/src/cast/list.rs#L227-L233
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   Use `take` kernel to construct values array instead of `MutableArrayData`. 
Would need to see some benchmarks to prove this is a performance benefit. We 
also need to be careful of edge cases, see my comment:
   
   - https://github.com/apache/arrow-rs/pull/9274#discussion_r2749221079
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features 
you've considered.
   -->
   
   If this isn't a significant performance benefit we leave the implementation 
as is.
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to