jonkeane commented on PR #49128: URL: https://github.com/apache/arrow/pull/49128#issuecomment-3841632668
Thanks for submitting this PR. I am inclined to accept it, I think the changes are good. But I would love to have a test in our CI that would catch if we (accidentally) add another place we need to guard against. What about adding a new crossbow job like this one: https://github.com/apache/arrow/blob/7532327adb2cf7bf59e3d6eca0c42641ec8792f7/dev/tasks/tasks.yml#L708-L714 Something like: ``` test-r-dataset-without-parquet: ci: github template: docker-tests/github.linux.yml params: env: ARROW_DATASET: ON ARROW_PARQUET: OFF image: ubuntu-r-only-r ``` How does that sound? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
