paleolimbot commented on PR #828: URL: https://github.com/apache/arrow-nanoarrow/pull/828#issuecomment-3843530720
Sorry for being slow to respond here...this fell off my radar! You're completely correct that the ideal situation is accumulating R vectors in place, much like `std::vector()` would do. That ability sort of exists in the internal C code but isn't all the way supported (there exists the ability to "reserve" + "fill", but not "reallocate"). Ideally one could "just" implement the "reallocate" part which would solve something similar. I chose a slightly simpler approach in this PR because it was less error prone but accumulating it all in place is also an improvement worth pursuing. Specifically with respect to #823, when we do implement that we need to do it without an `rbind()` or `c()` because that can be slow. One other improvement will be to make the internal `protect`ion cheaper (can be done using cpp11). Even though we don't need it for collection any longer, it does show up in other cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
