rok commented on code in PR #48769:
URL: https://github.com/apache/arrow/pull/48769#discussion_r2761587502
##########
cpp/src/arrow/compute/kernels/scalar_nested.cc:
##########
@@ -183,10 +183,9 @@ struct ListSlice {
const auto* list_type = checked_cast<const BaseListType*>(list_array.type);
// Pre-conditions
- if (opts.start < 0 || (opts.stop.has_value() && opts.start >=
opts.stop.value())) {
- // TODO(ARROW-18281): support start == stop which should give empty lists
+ if (opts.start < 0 || (opts.stop.has_value() && opts.start >
opts.stop.value())) {
return Status::Invalid("`start`(", opts.start,
- ") should be greater than 0 and smaller than
`stop`(",
Review Comment:
Why switch from words ('greater than') to symbols ('>=') while keeping the
other bound as words? Either is ok, let's just keep it consistent. I'd slightly
prefer keeping to words.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
