codephage2020 commented on issue #9337: URL: https://github.com/apache/arrow-rs/issues/9337#issuecomment-3844790380
> I wonder if we should change the scope of the new API to something like `with_timezone/to_timezone` where `with_timezone(naive: NaiveDateTime, tz: Option<Tz>) -> Option<i64>`. > make sense to me , I plan to keep `make_value` for backward compatibility and add a new `from_naive_datetime(naive: NaiveDateTime, tz: Option<&Tz>) -> Option<i64>` method This naming is consistent with from_naive_datetime and from_datetime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
