alamb commented on PR #9317:
URL: https://github.com/apache/arrow-rs/pull/9317#issuecomment-3853317064
🤔 the benchmarks seem to show a slowdown
```
group
buffer_reuse main
-----
------------ ----
arrow_array_reader/StringDictionary/dictionary encoded, optional, no NULLs
1.00 337.0±1.63µs ? ?/sec 1.00
338.1±2.11µs ? ?/sec
arrow_array_reader/StringViewArray/dictionary encoded, mandatory, no NULLs
1.00 150.5±1.92µs ? ?/sec 1.01
151.9±3.50µs ? ?/sec
arrow_array_reader/StringViewArray/dictionary encoded, optional, half NULLs
1.28 203.5±1.59µs ? ?/sec 1.00
159.6±3.16µs ? ?/sec
arrow_array_reader/StringViewArray/dictionary encoded, optional, no NULLs
1.05 143.7±3.24µs ? ?/sec 1.00
137.3±2.33µs ? ?/sec
arrow_array_reader/StringViewArray/plain encoded, mandatory, no NULLs
1.05 379.9±2.09µs ? ?/sec 1.00
361.8±3.73µs ? ?/sec
arrow_array_reader/StringViewArray/plain encoded, optional, half NULLs
1.14 330.7±1.99µs ? ?/sec 1.00
289.4±2.04µs ? ?/sec
arrow_array_reader/StringViewArray/plain encoded, optional, no NULLs
1.05 388.5±2.68µs ? ?/sec 1.00
371.2±7.93µs ? ?/sec
```
I will rerun them and see if we can reproduce the numbers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
