AliRana30 commented on issue #49153:
URL: https://github.com/apache/arrow/issues/49153#issuecomment-3856581131
@pitrou @rok,
Thanks for the guidance! Based on the discussion, I’ve reviewed the existing
deprecations and would like to start **conservatively**, focusing on **C++
only** and on deprecations whose grace periods have clearly elapsed.
## Proposed Removal Order (C++ only)
### Phase 1 — Ready to Remove
1. **`decimal()` factory function**
- Deprecated in **v18.0.0** (~6 years ago)
- Declared in `cpp/src/arrow/type_fwd.h`
- **No usages found** → safest starting point
2. **`HasValidityBitmap()` function**
- Deprecated in **v17.0.0** (~7 years ago)
- Defined in `cpp/src/arrow/ipc/metadata_internal.h`
- 4 usages in the IPC module, all with straightforward replacements
3. **`ServerAuthHandler::IsValid()` old signature**
- Deprecated in **v13.0.0** (11+ years ago)
- Located in the Flight module
4. **`GetRecordBatchReader()` Status-returning overloads**
- Deprecated in **v21.0.0** (~4 years ago)
- Implemented in `cpp/src/parquet/arrow/reader.cc`
- Can be migrated to the `Result<T>`-returning APIs
### Question
Would you recommend also including **v22–v24** deprecations, or keeping this
initial cleanup limited to older ones?
## My Approach
I’ll submit **small, focused PRs**, starting with the `decimal()` factory
removal (zero usages), and proceed incrementally for easier review.
Does this plan sound reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
