etseidl commented on code in PR #9353:
URL: https://github.com/apache/arrow-rs/pull/9353#discussion_r2771452779
##########
parquet/src/file/properties.rs:
##########
@@ -203,10 +203,23 @@ impl WriterProperties {
/// Note: this is a best effort limit based on the write batch size
///
/// For more details see
[`WriterPropertiesBuilder::set_data_page_size_limit`]
+ /// and [`WriterPropertiesBuilder::set_column_data_page_size_limit`].
Review Comment:
I find it confusing that this setting will break from all other per-column
settings in that it exists on both the `WriterProperties` and
`ColumnProperties`. I think it would be better to remove `data_page_size_limit`
from the `WriterProperties` and rely on the value set on the `ColumnProperties`
(either the specific column or the default).
##########
parquet/src/file/properties.rs:
##########
@@ -534,6 +547,9 @@ impl WriterPropertiesBuilder {
///
/// Note: this is a best effort limit based on value of
/// [`set_write_batch_size`](Self::set_write_batch_size).
+ ///
+ /// This value acts as the default for all columns and can be overridden
with
+ /// [`Self::set_column_data_page_size_limit`].
Review Comment:
Similarly, I think this should move down to the "Setters for any column
(global)" section below (line 735 or so) and use the same pattern as other
per-column settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
