Jefffrey commented on code in PR #9363:
URL: https://github.com/apache/arrow-rs/pull/9363#discussion_r2771838580
##########
arrow-string/src/length.rs:
##########
@@ -175,6 +176,18 @@ pub fn bit_length(array: &dyn Array) -> Result<ArrayRef,
ArrowError> {
vec![*len * 8; array.len()].into(),
array.nulls().cloned(),
)?)),
+ DataType::BinaryView => {
+ let list = array.as_binary_view();
+ let values = list
+ .views()
+ .iter()
+ .map(|view| (*view as i32).wrapping_mul(8))
Review Comment:
We do use `i32` above for the `Utf8View` arm so I assume this is being
consistent with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
