[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #9861: ARROW-12166: [C++][Gandiva] Implements CONVERT_TO(value, type) function

[GitBox]

anthonylouisbsb commented on a change in pull request #9861:
URL: https://github.com/apache/arrow/pull/9861#discussion_r623606472



##########
File path: cpp/src/gandiva/function_registry_string.cc
##########
@@ -225,6 +225,67 @@ std::vector<NativeFunction> GetStringFunctionRegistry() {
                      "convert_replace_invalid_fromUTF8_binary",
                      NativeFunction::kNeedsContext),
 
+      NativeFunction("convert_todouble", {}, DataTypeVector{float64()}, 
binary(),

Review comment:
       Should I need to apply that sugestion to other functions too? I am 
asking it because in this comment 
https://github.com/apache/arrow/pull/9861#discussion_r622908353 you said to not 
use case-sensitive names




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org