shashbha14 opened a new pull request, #49182: URL: https://github.com/apache/arrow/pull/49182
This fixes the CRAN build failure on macOS 13.3 with Apple Clang 14.0.0. The problem is that `std::floating_point<T>` is a C++20 concept, but Apple Clang 14.0.0 doesn't have full support for it yet. When building, it errors out saying it can't find `floating_point` in the `std` namespace. I swapped it out for `std::is_floating_point_v<T>` instead, which is basically the same thing but uses a C++17 variable template that works fine with older compilers. I also added `#include <type_traits>` since that's where `is_floating_point_v` lives. Behavior is unchanged - still matches all the floating point types (float, double, long double) plus util::Float16. Just using a different approach that the older compiler can handle. Fixes #49176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
