ennuite commented on issue #577:
URL: https://github.com/apache/arrow-java/issues/577#issuecomment-3875050432

   @nicornk I checked out the relevant part of this codebase. There was a 
refactor that moved the `NettyChannelBuilder` call to `NettyClientBuilder`, see 
https://github.com/apache/arrow-java/pull/660/changes, but the lines weren't 
changed.
   
   I also confirmed that grpc-java itself recommends against using the current 
API for HTTP/TCP sockets, see 
https://github.com/grpc/grpc-java/blob/73abb48547df4cbaadddfa5bd6a82ef387fac800/netty/src/main/java/io/grpc/netty/NettyChannelBuilder.java#L125
 This is not a URL parsing error, it's an incorrect usage of the gRPC 
NettyChannelBuilder.
   
   I'm working on a PR to fix this. The fix itself is trivial: I'm writing unit 
tests for it. 
   
    
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to