kou commented on code in PR #49160:
URL: https://github.com/apache/arrow/pull/49160#discussion_r2785898297
##########
cpp/src/gandiva/precompiled/string_ops_test.cc:
##########
@@ -387,6 +387,12 @@ TEST(TestStringOps, TestRepeat) {
EXPECT_EQ(std::string(out_str, out_len), "");
EXPECT_THAT(ctx.get_error(), ::testing::HasSubstr("Repeat number can't be
negative"));
ctx.Reset();
+
+ out_str = repeat_utf8_int32(ctx_ptr, "aa", 2,
+ std::numeric_limits<int32_t>::max() / 2 + 1,
&out_len);
+ EXPECT_EQ(std::string(out_str, out_len), "");
+ EXPECT_THAT(ctx.get_error(), ::testing::HasSubstr("Would overflow maximum
output size"));
Review Comment:
```suggestion
EXPECT_THAT(ctx.get_error(),
::testing::HasSubstr("Would overflow maximum output size"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
