gyanranjanpanda commented on code in PR #9373: URL: https://github.com/apache/arrow-rs/pull/9373#discussion_r2786449871
########## arrow-select/tests/test_concat_dictionary_boundary.rs: ########## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#[cfg(test)] +mod test_concat_dictionary_boundary { Review Comment: test_concat_u8_dictionary_256_values Passes with exactly 256 unique values (this previously failed). test_concat_u8_dictionary_257_values_fails Correctly returns an error when exceeding the u8 boundary (257 values). test_concat_u16_dictionary_65536_values Passes with exactly 65,536 unique values (this previously failed). test_concat_returns_error_not_panic Verifies that overflow results in a proper ArrowError instead of a panic. Let me know if you'd like any additional edge cases covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
