mapleFU commented on code in PR #48468:
URL: https://github.com/apache/arrow/pull/48468#discussion_r2788524407
##########
cpp/src/parquet/arrow/writer.cc:
##########
@@ -480,19 +483,28 @@ class FileWriterImpl : public FileWriter {
return Status::OK();
};
+ const int64_t max_row_group_length =
this->properties().max_row_group_length();
+ const int64_t max_row_group_bytes =
this->properties().max_row_group_bytes();
+
int64_t offset = 0;
while (offset < batch.num_rows()) {
- const int64_t batch_size =
- std::min(max_row_group_length - row_group_writer_->num_rows(),
- batch.num_rows() - offset);
- RETURN_NOT_OK(WriteBatch(offset, batch_size));
- offset += batch_size;
-
- // Flush current row group writer and create a new writer if it is full.
- if (row_group_writer_->num_rows() >= max_row_group_length &&
- offset < batch.num_rows()) {
+ if (row_group_writer_->num_rows() >= max_row_group_length ||
+ row_group_writer_->EstimatedTotalCompressedBytes() >=
max_row_group_bytes) {
+ // Current row group is full, start a new one.
RETURN_NOT_OK(NewBufferedRowGroup());
}
+ int64_t batch_size = std::min(max_row_group_length -
row_group_writer_->num_rows(),
+ batch.num_rows() - offset);
+ if (auto avg_row_size = EstimateCompressedBytesPerRow()) {
Review Comment:
Assuming a sorted file with nulls first, would this given small avg row size
firstly and adjust multiple rounds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
