medwards commented on a change in pull request #236:
URL: https://github.com/apache/arrow-rs/pull/236#discussion_r623871342
##########
File path: arrow/src/compute/kernels/sort.rs
##########
@@ -1556,6 +1559,28 @@ mod tests {
Some(3),
vec![Some(1.0), Some(2.0), Some(3.0)],
);
+
+ // limit that includes some extra nulls
+ test_sort_primitive_arrays::<Float64Type>(
Review comment:
Added
```
(len < null.count(), null_last)
(len > null.count(), null_first)
```
I believe the other new tests cover the remaining cases you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
