jonkeane commented on PR #49216: URL: https://github.com/apache/arrow/pull/49216#issuecomment-3882008603
Success at replicating CRAN's old build system failures https://github.com/ursacomputing/crossbow/actions/runs/21892102160/job/63199955397#step:9:1773 ``` Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:38: error: no template named 'floating_point' in namespace 'std'; did you mean 'is_floating_point'? 281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>; | ~~~~~^~~~~~~~~~~~~~ | is_floating_point /Library/Developer/CommandLineTools/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/type_traits:860:50: note: 'is_floating_point' declared here 860 | template <class _Tp> struct _LIBCPP_TEMPLATE_VIS is_floating_point | ^ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:281:56: error: expected '(' for function-style cast or type construction 281 | concept CFloatingPointConcept = std::floating_point<T> || std::same_as<T, util::Float16>; | ~~~~~~~~~~~~~~~~~~~~~~ ^ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'? 299 | template <CFloatingPointConcept CType> | ^~~~~~~~~~~~~~~~~~~~~ | FloatingPointType /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here 336 | class ARROW_EXPORT FloatingPointType : public NumberType { | ^ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:299:33: error: non-type template parameter has non-literal type 'FloatingPointType' 299 | template <CFloatingPointConcept CType> | ^ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors 336 | class ARROW_EXPORT FloatingPointType : public NumberType { | ^ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:300:20: error: template argument for template type parameter must be a type 300 | struct AntiExtrema<CType> { | ^~~~~ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:287:20: note: template parameter is declared here 287 | template <typename CType> | ^ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:11: error: unknown type name 'CFloatingPointConcept'; did you mean 'FloatingPointType'? 317 | template <CFloatingPointConcept CType> | ^~~~~~~~~~~~~~~~~~~~~ | FloatingPointType /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' declared here 336 | class ARROW_EXPORT FloatingPointType : public NumberType { | ^ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:317:33: error: non-type template parameter has non-literal type 'FloatingPointType' 317 | template <CFloatingPointConcept CType> | ^ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/type.h:336:20: note: 'FloatingPointType' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors 336 | class ARROW_EXPORT FloatingPointType : public NumberType { | ^ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:318:17: error: template argument for template type parameter must be a type 318 | struct MinMaxOp<CType> { | ^~~~~ /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/compute/kernels/hash_aggregate.cc:311:20: note: template parameter is declared here 311 | template <typename CType> | ^ 8 errors generated. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
