cetra3 opened a new pull request, #9392: URL: https://github.com/apache/arrow-rs/pull/9392
The `half::f16` type no longer implements `rand::distributions::Standard`, so benchmarks using `rng.random::<f16>()` fail to compile. Use `f16::from_f32(rng.random::<f32>())` instead, and route Float16 array generation through `create_f16_array` which already handles this. # Which issue does this PR close? N/A # Rationale for this change The `half::f16` type no longer implements `rand::distributions::Standard`, so benchmarks using `rng.random::<f16>()` fail to compile. Use `f16::from_f32(rng.random::<f32>())` instead, and route Float16 array generation through `create_f16_array` which already handles this. # What changes are included in this PR? Some small changes to get benchmarks working # Are these changes tested? Yeah we can run benches # Are there any user-facing changes? Nope -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
