rluvaton commented on code in PR #9393:
URL: https://github.com/apache/arrow-rs/pull/9393#discussion_r2793131355
##########
arrow-buffer/src/builder/mod.rs:
##########
@@ -199,8 +199,9 @@ impl<T: ArrowNativeType> BufferBuilder<T> {
/// ```
#[inline]
pub fn append(&mut self, v: T) {
- self.reserve(1);
- self.buffer.push(v);
+ self.buffer.reserve(std::mem::size_of::<T>());
Review Comment:
Can we revert this? as the `reserve` already does that and it should be
inlined
```suggestion
self.reserve(1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
