pitrou commented on code in PR #47994:
URL: https://github.com/apache/arrow/pull/47994#discussion_r2793336007
##########
cpp/src/arrow/util/bpacking.cc:
##########
@@ -50,19 +51,19 @@ struct UnpackDynamicFunction {
} // namespace
template <typename Uint>
-void unpack(const uint8_t* in, Uint* out, int batch_size, int num_bits, int
bit_offset) {
+void unpack(const uint8_t* in, Uint* out, const UnpackOptions& opts) {
#if defined(ARROW_HAVE_NEON)
- return unpack_neon(in, out, batch_size, num_bits, bit_offset);
+ return bpacking::unpack_neon(in, out, opts);
#else
static DynamicDispatch<UnpackDynamicFunction<Uint> > dispatch;
- return dispatch.func(in, out, batch_size, num_bits, bit_offset);
+ return dispatch.func(in, out, opts);
#endif
}
-template void unpack<bool>(const uint8_t*, bool*, int, int, int);
-template void unpack<uint8_t>(const uint8_t*, uint8_t*, int, int, int);
-template void unpack<uint16_t>(const uint8_t*, uint16_t*, int, int, int);
-template void unpack<uint32_t>(const uint8_t*, uint32_t*, int, int, int);
-template void unpack<uint64_t>(const uint8_t*, uint64_t*, int, int, int);
+template void unpack<bool>(const uint8_t*, bool*, const UnpackOptions&);
Review Comment:
Kind of, though we might want to revisit later anyway. Not necessary for
this PR in any case!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
