alamb commented on code in PR #9375:
URL: https://github.com/apache/arrow-rs/pull/9375#discussion_r2795495736
##########
parquet/tests/arrow_reader/io/mod.rs:
##########
@@ -244,6 +244,8 @@ struct TestParquetFile {
/// The operation log for IO operations performed on this file
ops: Arc<OperationLog>,
/// The (pre-parsed) parquet metadata for this file
+ // TODO: this is unused; consider removing it.
+ #[allow(dead_code)]
Review Comment:
we can probably replace it with `cfg(feature(async))` or something
##########
parquet/tests/arrow_reader/io/mod.rs:
##########
@@ -572,6 +578,8 @@ impl OperationLog {
/// accessed by the specified range
///
/// It behaves the same as [`add_entry_for_range`] but for multiple ranges.
+ // TODO: this is unused; consider removing it.
Review Comment:
I suspect it needs `cfg(feature(async))` or something
However, avoiding the warnings is better in my mind and we can tighten up
the #allow(dead_code) stuff as a follow on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
