alinaliBQ commented on code in PR #49220:
URL: https://github.com/apache/arrow/pull/49220#discussion_r2795221993
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -3023,8 +3028,8 @@ function(build_cares)
if(APPLE)
# libresolv must be linked from c-ares version 1.16.1
find_library(LIBRESOLV_LIBRARY NAMES resolv libresolv REQUIRED)
- set_target_properties(c-ares::cares PROPERTIES INTERFACE_LINK_LIBRARIES
- "${LIBRESOLV_LIBRARY}")
+ set_target_properties(c-ares PROPERTIES INTERFACE_LINK_LIBRARIES
+ "${LIBRESOLV_LIBRARY}")
endif()
Review Comment:
This change fixes error:
```
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:3032
(set_target_properties):
set_target_properties can not be used on an ALIAS target.
```
Without this change, we have failed run with `c-ares::cares` being used.
Log:
https://github.com/Bit-Quill/arrow/actions/runs/21459770235/job/61809740997?pr=153#step:7:540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
