lidavidm commented on code in PR #3871:
URL: https://github.com/apache/arrow-adbc/pull/3871#discussion_r2796317505
##########
c/include/arrow-adbc/adbc.h:
##########
@@ -1059,17 +1178,18 @@ struct ADBC_EXPORT AdbcDriver {
/// the AdbcDriverInitFunc is greater than or equal to
/// ADBC_VERSION_1_1_0.
///
- /// For a 1.0.0 driver being loaded by a 1.1.0 driver manager: the
- /// 1.1.0 manager will allocate the new, expanded AdbcDriver struct
- /// and attempt to have the driver initialize it with
- /// ADBC_VERSION_1_1_0. This must return an error, after which the
- /// driver will try again with ADBC_VERSION_1_0_0. The driver must
- /// not access the new fields, which will carry undefined values.
+ /// When a driver implementing an older spec is loaded by a newer
+ /// driver manager, the newer manager will allocate the new, expanded
+ /// AdbcDriver struct and attempt to have the driver initialize it with
+ /// the newer version. This must return an error, after which the driver
+ /// will try again with successively older versions all the way back to
+ /// ADBC_VERSION_1_0_0. The driver must not access the new fields,
+ /// which will carry undefined values.
Review Comment:
The new wording looks good but it seems the old wording is up here (I guess
the old wording is from the previous revision). Maybe we just remove it from
one of these places? No need to duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
