kou commented on code in PR #48578:
URL: https://github.com/apache/arrow/pull/48578#discussion_r2796962549


##########
cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc.sh:
##########


Review Comment:
   Could you add this to lint targets?
   
   ```diff
   diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
   index 566ade9172..a33aa3acb4 100644
   --- a/.pre-commit-config.yaml
   +++ b/.pre-commit-config.yaml
   @@ -353,6 +353,7 @@ repos:
              ?^cpp/build-support/update-thrift\.sh$|
              ?^cpp/examples/minimal_build/run\.sh$|
              ?^cpp/examples/tutorial_examples/run\.sh$|
   +          ?^cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc\.sh$|
              ?^dev/release/05-binary-upload\.sh$|
              ?^dev/release/08-binary-verify\.sh$|
              ?^dev/release/binary-recover\.sh$|
   @@ -379,6 +380,7 @@ repos:
            files: >-
              (
              ?^ci/scripts/python_test_type_annotations\.sh$|
   +          ?^cpp/src/arrow/flight/sql/odbc/install/mac/install_odbc\.sh$|
              ?^dev/release/05-binary-upload\.sh$|
              ?^dev/release/binary-recover\.sh$|
              ?^dev/release/post-03-binary\.sh$|
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to