ianmcook commented on a change in pull request #9999:
URL: https://github.com/apache/arrow/pull/9999#discussion_r624247956
##########
File path: r/tests/testthat/test-dplyr-mutate.R
##########
@@ -32,59 +47,23 @@ test_that("mutate() is lazy", {
)
})
-test_that("basic mutate", {
- expect_dplyr_equal(
- input %>%
- select(int, chr) %>%
- filter(int > 5) %>%
- mutate(int = int + 6L) %>%
- collect(),
- tbl
- )
-})
-
-test_that("mutate() with NULL inputs", {
- expect_dplyr_equal(
- input %>%
- mutate(int = NULL) %>%
- collect(),
- tbl
- )
-})
+# similar to
https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L1-L10
Review comment:
These "similar to" comments are helpful, and I think it's worth keeping
them in, but:
- At least one of them points to the wrong line numbers, so please check
them and fix
- They will no longer point to the correct line numbers if `test-mutate.r`
in dplyr changes, so please change the URLs to use a commit hash in place of
`master`. For example, this URL could change to:
`https://github.com/tidyverse/dplyr/blob/04454209ea069939d3335c43846c85c725547a89/tests/testthat/test-mutate.r#L1-L10`.
That URL will always point to the correct test even if `test-mutate.r` changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
