etseidl commented on PR #9374:
URL: https://github.com/apache/arrow-rs/pull/9374#issuecomment-3898006624
I think we shouldn't be thrown off by the benches. Compare the latest bench
of this PR
```
group
main
reset-partial-record-state-after-skipping-all-records
-----
----
-----------------------------------------------------
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/byte_stream_split
encoded, mandatory, no NULLs 1.00 160.5±0.72µs ? ?/sec 1.22
195.6±2.97µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/byte_stream_split
encoded, optional, half NULLs 1.00 300.9±4.42µs ? ?/sec 1.12
338.1±6.72µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/byte_stream_split
encoded, optional, no NULLs 1.00 164.7±2.33µs ? ?/sec 1.21
199.1±3.93µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/plain encoded,
mandatory, no NULLs 1.00 76.8±1.39µs ? ?/sec
1.54 118.2±4.05µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/plain encoded,
optional, half NULLs 1.00 257.3±1.94µs ? ?/sec
1.17 300.9±5.17µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/plain encoded,
optional, no NULLs 1.00 81.0±0.54µs ? ?/sec
1.49 121.1±0.99µs ? ?/sec
```
to the same from #9406
```
group
ets_9374 main
-----
-------- ----
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/byte_stream_split
encoded, mandatory, no NULLs 1.00 153.4±0.33µs ? ?/sec 1.27
194.8±1.77µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/byte_stream_split
encoded, optional, half NULLs 1.00 318.1±3.13µs ? ?/sec 1.06
336.6±3.60µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/byte_stream_split
encoded, optional, no NULLs 1.00 157.1±0.56µs ? ?/sec 1.26
198.2±0.86µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/plain encoded,
mandatory, no NULLs 1.00 75.7±0.18µs ? ?/sec
1.56 118.5±0.87µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/plain encoded,
optional, half NULLs 1.00 278.7±0.91µs ? ?/sec
1.08 300.6±4.92µs ? ?/sec
arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/plain encoded,
optional, no NULLs 1.00 79.5±0.22µs ? ?/sec
1.55 123.1±3.24µs ? ?/sec
```
and notice how the `main` times have flipped. I think the regressions are
more an artifact of the environment than anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
