robreeves commented on PR #49009: URL: https://github.com/apache/arrow/pull/49009#issuecomment-3898244683
> Thanks @cbb330 for the contribution and @raulcd for the suggestion! IMHO, it would be good to have a complete PoC PR to demonstrate the big picture and them split it into smaller PRs one by one for better review experience. Generally I agree with smaller PRs with focused changes, but I also feel this set of 15 PRs is broken down too small and could actually result in bugs being missed since. For example, I don't think the second PR needs to be a standalone PR to add the builder `BuildMinMaxExpression`. Please add unit tests too. I checked the first few and didn't see any. Let me know if I missed them in a later PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
