mzabaluev commented on code in PR #9397:
URL: https://github.com/apache/arrow-rs/pull/9397#discussion_r2809837201
##########
arrow-avro/src/reader/vlq.rs:
##########
@@ -97,6 +97,34 @@ fn read_varint_slow(buf: &[u8]) -> Option<(u64, usize)> {
None
}
+pub(crate) fn skip_varint(buf: &[u8]) -> Option<usize> {
+ if let Some(array) = buf.get(..10) {
+ return skip_varint_array(array.try_into().unwrap());
+ }
+ skip_varint_slow(buf)
+}
+
+fn skip_varint_array(buf: [u8; 10]) -> Option<usize> {
+ // Using buf.into_iter().enumerate() regresses performance by 1% on x86-64
+ #[allow(clippy::needless_range_loop)]
+ for idx in 0..10 {
+ if buf[idx] < 0x80 {
+ return Some(idx + 1);
+ }
+ }
+ None
+}
Review Comment:
Fixed this as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
