crepererum commented on PR #644: URL: https://github.com/apache/arrow-rs-object-store/pull/644#issuecomment-3908546623
Looks clean, thank you. One suggestions: Could you add a small note about the `tokio` feature and the fact that the core trait don't require `tokio` to this paragraph here: https://github.com/apache/arrow-rs-object-store/blob/030f29d59ec055741e5f4de55e8a004d8fa44d5b/src/lib.rs#L70-L98 Based on your `cargo tree` output, I think we may want to double-check our usage of the `futures` umbrella crate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
