shreyans800755 commented on issue #29309: URL: https://github.com/apache/arrow/issues/29309#issuecomment-3910628864
Hi I tried to work on this, but I think current implementation might be intentional. There are other builds which have the same interfaces. For ex: https://github.com/apache/arrow/blob/111495870686ef269254232b876de3aee2f919b6/cpp/src/arrow/array/builder_decimal.cc#L143 And we have places which deal with generic types and require interfaces to be compatible. For ex: https://github.com/apache/arrow/blob/111495870686ef269254232b876de3aee2f919b6/cpp/src/arrow/builder.cc#L199 We can put if constexpr or some metaprogramming here to construct builder per params. But that doesn't seem to be the cleanest approach either. Please let me know what you think. @asfimport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
