axreldable commented on code in PR #1016:
URL: https://github.com/apache/arrow-java/pull/1016#discussion_r2816982908
##########
flight/flight-core/src/main/java/org/apache/arrow/flight/client/ClientCookieMiddleware.java:
##########
@@ -100,10 +100,7 @@ public void onBeforeSendingHeaders(CallHeaders
outgoingHeaders) {
@Override
public void onHeadersReceived(CallHeaders incomingHeaders) {
- final Iterable<String> setCookieHeaders =
incomingHeaders.getAll(SET_COOKIE_HEADER);
- if (setCookieHeaders != null) {
- factory.updateCookies(setCookieHeaders);
- }
+ factory.updateCookies(incomingHeaders.getAll(SET_COOKIE_HEADER));
Review Comment:
I believe it relates to the PR as `CallHeaders.getAll(String key)` doesn't
return `null`, so we don't have to check it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
