edrevo opened a new pull request #232:
URL: https://github.com/apache/arrow-datafusion/pull/232
# Which issue does this PR close?
Closes #76.
# Rationale for this change
From the issue:
> Having the ability to set an external/advertised hostname is great since
it provides users a lot of flexibility in network deployments. However, having
it a required argument is a pain for the most common scenario, where the
scheduler, client and executors talk to each other in the same network (e.g.
k8s or docker-compose).
>
> We should make the external hostname optional. If the scheduler receives
executor metadata without a hostname, it should register the caller's IP
address as the hostname.
>
> This will make it easier to deploy the executors as a kubernetes
deployment, or to docker-compose scale ballista-executor= in the integration
tests.
# What changes are included in this PR?
- Make hostname optional upon executor registration
- Removed a bunch of old code in the planner
# Are there any user-facing changes?
Advertised hostname is now optional when launching the executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
