raulcd commented on issue #36411: URL: https://github.com/apache/arrow/issues/36411#issuecomment-3914952905
> Do you have any idea how it would work with future enhancements like building the C++ dependency from source or integrating sanitizers? Meson handles those pretty well, so I'd be curious to know the CMake vision by comparison. This would be a CMake problem more than a scikit-build-core problem. As we can see on the PR scikit-build-core is just a thin wrapper for CMake build invocation. For example we already have `PYARROW_BUNDLE_ARROW_CPP` which works as expected with `scikit-build-core`. If we would want to build Arrow C++ alongside PyArrow first we would have to scope the problem, do we want to build from a PyArrow sdist or do we want to build from the monorepo? In the sdist case we could use `FetchContent` to download and build Arrow CPP, in the mono repo experience we could make `python/CMakeLists.txt` pull in the parent via `add_subdirectory(../cpp ...)` and build. I think those solve different audiences and use cases. In one case an end user trying to build PyArrow without Arrow CPP from a downloaded sdist on the other an Arrow developer wanting to build PyArrow without having to build Arrow CPP. I am wondering whether the use cases are sufficiently required bearing in mind that we provide pre-build wheels and conda packages with library granularity level, pre-built Arrow binaries in several package manager (linux packages, vcpkg, conan, homebrew, MinGW). @WillAyd Do you have a specific use case in mind for this? As per the sanitizers, it would be built similarly as how we build sanitizers today within Arrow CPP just some CMake flags that we can expose same as we expose `PYARROW_BUNDLE_ARROW_CPP`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
