liamzwbao commented on code in PR #9411:
URL: https://github.com/apache/arrow-rs/pull/9411#discussion_r2825146176
##########
arrow-buffer/src/buffer/null.rs:
##########
@@ -274,4 +284,49 @@ mod tests {
std::mem::size_of::<Option<NullBuffer>>()
);
}
+
+ #[test]
+ fn test_from_unsliced_buffer_with_nulls() {
+ // Buffer with some nulls: 0b10110010 = valid, null, valid, valid,
null, null, valid, null
+ let buf = Buffer::from([0b10110010u8]);
Review Comment:
Arrow uses LSB numbering and that's why this test failed. Could refer to the
[doc](https://arrow.apache.org/docs/format/Columnar.html#validity-bitmaps) to
fix the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
