kunalsinghdadhwal opened a new pull request, #9441:
URL: https://github.com/apache/arrow-rs/pull/9441
# Which issue does this PR close?
- Closes #9378
# Rationale for this change
the optimizations as listed in the issue description
- Align to 8 bytes
- Don't try to return a buffer with bit_offset 0 but round it to a multiple
of 64
- Use chunk_exact for the fallback path
# What changes are included in this PR?
When both inputs share the same sub-64-bit alignment (left_offset % 64 ==
right_offset % 64), the optimized path is used. This covers the common cases
(both offset 0, both sliced equally, etc.). The BitChunks fallback is retained
only when the two offsets have different sub-64-bit alignment.
# Are these changes tested?
Yes the tests are changed and they are included
# Are there any user-facing changes?
Yes, this is a minor breaking change to from_bitwise_binary_op:
- The returned BooleanBuffer may now have a non-zero offset (previously
always 0)
- The returned BooleanBuffer may have padding bits set outside the logical
range in values()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
